Get origin and date for VT severities from OSP #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the VTs via OSP, the origin and date elements are now also read and stored in the database.
This also covers some previous pull requests.
jjnicola
suggested changes
Nov 20, 2020
src/manage_sql_nvts.c
Outdated
| parsed_severity_date = strtol (entity_text (severity_date), | ||
| NULL, 10); | ||
| else | ||
| parsed_severity_date = nvti_modification_time (nvti); |
There was a problem hiding this comment.
This should use the nvti creation date.
There was a problem hiding this comment.
Changed in aa5b0ed.
The severity is usually set fairly early in VT development so this is often more accurate than the modification time.
jjnicola
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When getting the VTs via OSP, the origin and date elements are now also
read and stored in the database.
Why:
This is part of our plan to add extended severity information.
How did you test it:
Tested by running
gvmd --rebuildwith an up to date scanner and NVTs feed and then checking the response to aget_infoGMP command getting the details of an NVT that has the new fields, like1.3.6.1.4.1.25623.1.0.117034.Checklist: