Drop severity type "debug" #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and "Debug Message" as message type anymore.
for the severity classes.
This is not used anywhere anymore.
Also remove all then unused variables.
Such messages are assigned type "Error Message".
mattmundell
approved these changes
Oct 12, 2020
|
|
||
| /* Replace any result type "Debug Message" by "Error Message". */ | ||
|
|
||
| sql ("UPDATE results SET type = 'Error Message' WHERE type = 'Debug Message';"); |
There was a problem hiding this comment.
Technically I guess this should set severity to -3.0. But realistically I don't think there are any debug messages out there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Any code to handle the message type "Debug Message" and the severity type "Debug" is removed.
Why:
This removes unneeded code and thus simplifies code. Also, this potentially makes code faster
as it removes useless conditionals from result loops.
The creation of Debug Messages was removed with the release of OpenVAS-5 in March 2012.
How:
Testing the changes was about testing the scan results keep the same.
Basically it is dead code with no influence other than consuming CPU cycles.
Checklist: