Reduce severity classes #1288
Merged
Reduce severity classes #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2020
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
mattmundell
requested changes
Sep 14, 2020
|
Also, it's missing the changes to the GMP doc. |
Returns always the same string with the nist classes. 'pci-dss' is removed.
The nist classes are now always applied for the computations.
The computations for class 'nist' are now always applied.
Now always the nist classes are applied.
The nist classes are applied anway, so do not pull the user setting about classes.
Copy over the actual evaluation into the main severity_in_level SQL function.
The places where it was called use the default string 'nist' directly.
The element "severity" with its meanwhile static value "nist" is removed from the element "authenticate_response".
Since there is only a single static classes, it does not need to be send anymore with its range details.
janowagner
force-pushed
the
reduce_severity_classes
branch
from
f1f877c
to
b41cbce
Compare
mattmundell
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for multiple severity class ranges is removed.
There is now only one classification scheme (the one previously
called "nist"). Actually there was only one other classification scheme called
"pci-dss". It wasn't used or needed.
With applying a single default scheme code and database operations can
be simplified.
Basically all code elements are removed, including a migrator
that removes any such setting from the database.
The "report" XML element does not include the severity classification with
its range details (as element ""severity_class) anymore and the "authenticate_response"
XML does not include the "severity" element anymore.
Checklist: