Reduce severity classes #1285
Merged
Reduce severity classes #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XML element "severity_class" will be empty in case security class is "bsi".
The class "classic" was remove with gvmd version 8.0 and the migrator replaced all occurances by class "nist".
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
mattmundell
approved these changes
Sep 2, 2020
The only confusion can happen in "My Settings", which is addressed by greenbone/gsa#2434 . |
Nice. So they will still appear in GMP GET_SETTINGS. How about removing the BSI settings from the db? |
on my agenda, but related to another aspect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of supported severity classes is reduced by removing last remains
of "classic" (deprecated since v8.0) and by removing "bsi" which is actually the same as "nist".
This cleans code and UI, without removing functionality.