Move EXE credential generation to a Python script #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The creator scripts do not have to be shell scripts so they are renamed to keep them consistent with scripts using other languages like Python.
Creating the EXE credential in an external script using a template makes the NSIS script generation easier to read, maintain and customize.
mattmundell
approved these changes
Aug 17, 2020
bjoernricks
reviewed
Aug 18, 2020
| nsis_script_file.write(nsis_script) | ||
|
|
||
| run = subprocess.run(["makensis", nsis_script_path]) | ||
| sys,exit(run.returncode) |
There was a problem hiding this comment.
There is typo. Needs to be sys.exit
There was a problem hiding this comment.
And the code should be put into a function that gets called instead
There was a problem hiding this comment.
These should be fixed in #1262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the EXE credential in an external script using a template makes
the NSIS script generation easier to read, maintain and customize.
Checklist: