Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon for shelter_type=public_transport #4317

Closed

Conversation

jdhoek
Copy link
Contributor

@jdhoek jdhoek commented Feb 2, 2021

The default shelter icon looks a bit strange for shelters tagged with shelter_type=public_transport; the minimal shelter type you would find at a bus or tram stop.

This commit introduces a distinct icon for this shelter type, and changes the colour of it to @transportation-icon to match the public transport stop itself.

This type of icon was suggested by @polarbearing in #4270.

Rendering

Screenshot from 2021-02-02 19-23-08

Seems to work okay with shelters mapped as buildings too:

Screenshot from 2021-02-02 19-29-16

At the very least no worse than the generic shelter icon.

Current icon and colour

Screenshot from 2021-02-02 19-30-14

Screenshot from 2021-02-02 19-31-19

The default shelter icon looks a bit strange for shelters tagged with
`shelter_type=public_transport`; the minimal shelter type you would find
at a bus or tram stop.

This commit introduces a distinct icon for this shelter type, and
changes the colour of it to `@transportation-icon` to match the public
transport stop itself.
@imagico
Copy link
Collaborator

imagico commented Feb 5, 2021

This suggestion clashes with a number of important principles of map design we tend to follow in OSM-Carto:

  • semantic homogeneity - map elements that are similar in meaning and purpose for the target map user should be similar in appearance while elements that fulfill very different functions should look different. The visual difference between different subtypes of shelters being larger than that between a shelter and an alpine hut or wilderness hut would therefore be fairly misleading.
  • function before physical appearance - we like to focus on function in map rendering and not on physical appearance. There is nothing in your symbol design that hints at the function of the feature in an explicit form without the mental detour of recognizing the similarity in physical shape to a very specific variant of the feature.
  • mind the target map user - our target map user is the potential global map user and not the de facto dominating urban European/North American population. That public transport shelters world wide predominantly have a form resembling the minimalist roof and wall urban tram stop type shelter is unlikely.
  • intuitive readability - we like the map to be intuitively readable without a map key as much as possible. That is the case for the shelter symbol, it is quite definitely often not the case for your suggestion.
  • avoiding confusion with mapped geometries - we try to avoid symbols to be mistaken for mapped geometries. The very abstract shape of your symbol of two lines at an angle is very prone to that.

It would be perfectly fine to use a variation of the shelter symbol to indicate a public transport shelter is tagged specifically as such with the variation not being that intuitive as long as the base symbol is still recognizable as the general shelter symbol and the variation is not directly misleading.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Feb 7, 2021

In Indonesia public transport shelters are more likely to look like this:

Pangkalan_ojek_Sinakma

That’s an ojek (motorcycle taxi?) stand, but local bus shelters are similar.

@jeisenbe
Copy link
Collaborator

@jdhoek would you be interested in either modifying the main amenity=shelter icon or modifying this new icon so that they are more similar, and so the function is more clear, as mentioned in #4317 (comment) ?

@jdhoek
Copy link
Contributor Author

jdhoek commented Feb 25, 2021

Public transport shelters all share the characteristic that there is no guarantee that they are suitable for more than a modicum of shelter while waiting for a bus or tram. Most are open to at least one side and are size constrained, and the icon should indicate that the goal of this type of shelter is quite different from a generic amenity=shelter, and may not provide the map user with the shelter sought.

In many, if not most countries such shelters are variations on a roof on stilts without walls or a roof with some minimal walls on at most three sides. Representing it as a little house that will definitely keep you dry in stormy weather is misleading.

I don't think anything I can suggest will address the list of negative points raised by @imagico. In fact, if I apply those conditions to almost any of the existing icons, they all fail. It effectively discourages the contribution of any new icons. I mean, the current shelter icon fails on points 2, 3, and 4 too.

@polarbearing
Copy link
Contributor

That public transport shelters world wide predominantly have a form resembling the minimalist roof and wall urban tram stop type shelter is unlikely.

Well is is meant to protect against the occasional rain shower and a bit from the wind. What else than a minimalist roof and some wall would be suitable for that? Closed buildings maybe, but they would probably be mapped as a bus station.

I respect @imagico's perfectionism, but lacking a perfect solution a pragmatic one will help as well. The icon is in transport-blue, and typically found in proximity to the bus stop. Thus some clues for the map user to relate it correctly.

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs revisiting the symbol design - it would need to be something that is universally recognizable as a subtype of shelter. More guidance can be found in the comments above.

@Blijbol
Copy link

Blijbol commented May 7, 2022

I added the rain from the existing shelter symbol to make it more similar and easier to recognise as a shelter:

shelter_public_transport

If one further wants to minimise the difference, it could also retain the same shelter colour instead of adopting the public transport colour.

@pnorman
Copy link
Collaborator

pnorman commented Jul 13, 2022

With the requested changes in #4317 (comment) and #4317 (review) unaddressed, I'm going to go ahead and close this as abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants