-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rendering for tourism=artwork #2236
Conversation
sent from a phone
yes, fountains can be very important public artwork, likely all of them are somehow artwork, at least those with sculptures (as opposed to nozzles only) as part of them (also other aspects might be artistic, like the composition of water, shapes created by the sprinkling water etc). |
I also thought that tourism=attraction would be useful to show some artworks earlier and others later, but the problem is that artwork and attraction share the same key (tourism=*)... |
sent from a phone
yes, hence the ;-) |
Better icon, let's try some of the most crowded artwork-tagged places (worst cases expected on z17):
In summary - it all looks much better than I expected and currently worst case tagging are in my hometown (see all zoom range here): So the problems are visible if some artworks are gathered together on a small area (Warsaw x2), especially without the visual pattern (Louvre), but if they are distributed somehow (Jardin du Luxembourg), especially more linear (Versailles, Vatican), the result is quite nice, even if there are much more of them. For me it's perfectly acceptable and the icon itself fits there. I still look for more interesting locations for testing. [EDIT:] "Best case" in Warsaw z17 for a change =} : |
2016-07-23 2:30 GMT+02:00 kocio-pl notifications@github.com:
a statue is not a suitable icon for all kinds of artwork, it only works |
The case is not closed, we're still discussing what would be a proper icon, see #855. This PR is to test these ideas in reality, so if you know some places where you think it really wouldn't work, for example, I'm happy to check them. BTW: I've noticed that Louvre is an interesting case, since there are a lot of tagged artworks which are inside the building, so we deal with indoor mapping interference there. |
sent from a phone
IMHO these are mistagged with respect to the wiki definition: 'A tag for public pieces of art.' (although this current definition is admittedly not very clear).E.g. I know of a private square with a private artwork, but both are visible and accessible 24/7 by the general public: http://www.openstreetmap.org/node/1311129517#map=19/52.51072/13.37587 |
Thanks, this looks like the best of the proposed suggestions to me. |
Have you noticed this code works from z17 (I haven't change this in the meantime)? I still don't know how can we make sure that fountain or memorial icons (or other amenities) will be rendered if given object is also tagged as an artwork, because I feel these functions are more important than artistic form. Does anybody know what code change is needed? |
Yes, if it appears to early we can still change this.
I think you could fix this by changing the order in the COALESCE. Keys can appear multiple times there, see for example man_made. |
Resolves #855.
This is rather not the end of the process, since artwork is very popular tag, but the real code to test rendering. Note that:
Reporting interesting locations all over the world would be useful for testing.
Sample locations in Warsaw (z18):
1)
2)
3)
4)
5)
6)