Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for tourism=artwork #855

Closed
matthijsmelissen opened this issue Aug 5, 2014 · 48 comments
Closed

Add rendering for tourism=artwork #855

matthijsmelissen opened this issue Aug 5, 2014 · 48 comments

Comments

@matthijsmelissen
Copy link
Collaborator

The tag tourism=artwork should be rendered with icon.

See also https://trac.openstreetmap.org/ticket/4529.

@Rovastar
Copy link
Contributor

Rovastar commented Aug 6, 2014

If the individual artwork was noteworthy it would be an attraction that would be rendered.

I would close

@matthijsmelissen
Copy link
Collaborator Author

Not sure. I think sculptures are always landmarks, even when they are not attractions.

@moliha
Copy link

moliha commented Aug 7, 2014

  • and if they are attractions, you can't se what kind of attraction - only a name - if it is known. I think an icon for artwork is needed.

@Rovastar
Copy link
Contributor

Rovastar commented Aug 7, 2014

We obviously could add icons for every possible tag but we don't we only add notable/worthy ones. I think currently there is a pause on adding new icons hence another reason for a close.

@matthijsmelissen
Copy link
Collaborator Author

there is a pause on adding new icons

Yes, but I think we can leave the issues open for the next phase.

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014
@neiljp
Copy link

neiljp commented Nov 21, 2014

Names of artworks would be useful to show as points; this is shown on the cycle map, and I definitely miss it on the regular map.

@1ec5
Copy link

1ec5 commented Nov 26, 2014

As of writing this comment, the lack of tourism=artwork rendering currently prevents the individual letters of the Hollywood sign from appearing on the map. The map only shows some trace of the sign because there’s a redundant tourism=attraction POI nearby.

@dieterdreist
Copy link

2014-11-26 18:44 GMT+01:00 Minh Nguyễn notifications@github.com:

The map only shows some trace of the sign because there’s a redundant
tourism=attraction POI nearby.

yes. this was re-added shortly after I had removed the duplication node
because of the already present, detailed site relation. The mapper wanted
to see something rendered on the main map. I think generally it is a
problem to render "tourism=attraction" and "name" without any other tags
that actually say what it is (it's kind of a catch-all, something that the
current style-team generally wants to get rid of). FYI, there is now a
ticket for osm2pgsql and maybe in the future we will have site-relations in
the rendering db so that a label for stuff like this can be displayed
without having to duplicate data.

cheers,
Martin

@kocio-pl
Copy link
Collaborator

kocio-pl commented Mar 7, 2015

I guess the icon is worth showing even without the name - at least for such artwork types as sculpture, statue or a stone. In the parks for example they are the common landmarks, together with some buildings and fountains (that's why I have created this ticket: #705).

@polarbearing
Copy link
Contributor

Currently 37500 occurrences, most of them nodes, about 2500 on ways (e.g., on walls).

@kocio-pl
Copy link
Collaborator

I guess this is so broad category, that I would rather wait for database reload, so we could know exact type and join them with corresponding memorial types. We could render them that way for example:

  • architecture - could be rendered like tourist attraction (with star)
  • mural/painting - icon showing the general "picture" could be good - but probably it would be good to have something like this for art galleries too, although not the same
  • sculpture - maybe some famous shape (other than statue)
  • statue - the same as memorial=statue (general "statue" shape could work)
  • stone - probably very similar (or the same) to rocks and memorial=stone

It's hard for me to imagine the general "artwork" icon, but I can test some ideas. If this is accepted, we wouldn't have to wait for anything more.

@jojo4u
Copy link

jojo4u commented Sep 11, 2015

I detailed some problems with tourism=attraction here: http://wiki.openstreetmap.org/wiki/Talk:Tag:tourism%3Dattraction

@kocio-pl
Copy link
Collaborator

What about something abstract like this?

@d1g
Copy link

d1g commented Apr 21, 2016

@kocio-pl yes, any icon will work.

Even coloured dot (similar to shop=yes), tourism=artwork features are important landmarks at z17+ levels (or even 16+).

I think they should be rendered equally with historic=memorial; but some metropolitan areas have too many sculptures IRL and rendering of tourism=artwork isn't important for them.

@kocio-pl
Copy link
Collaborator

Looks like eclipsing shapes doesn't work with such a limited matrix - it's hardly recognizable:

  1. artwork-14-7
    but a simpler idea might work:
  2. artwork-14-1

@Jotam
Copy link

Jotam commented Jul 13, 2016

I really like the general idea. But with the triangle at the bottom, it somehow reminds me of a vintage camera. Could the triangle be at the top again?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 13, 2016

Sure (4 seems to be balanced best of them):
3) artwork-14-13
4) artwork-14-14
5) artwork-14-15

@daganzdaanda
Copy link

  1. is a good icon.
    Without knowing it, I would not read it as "artwork", though. (Toy blocks = childcare would be my first guess). How do others interpret the three shapes?

Would a palette (like https://cdn0.iconfinder.com/data/icons/business-vector-tab-bar-icons/48/painter_palette-512.png ) be a good idea for all artworks? Or would we get complaints that a statue is not a painting...?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 18, 2016

IMO there is no sure solution, since it could also mean shop=art (in violet), art gallery or arts centre. I like abstract blocks as the artwork can be very different - like sculpture, graffiti, stone, painting, logo, installation... However I don't exclude palette if we agree about other possible uses of this symbol.

@d1g
Copy link

d1g commented Jul 18, 2016

I vote for no4.

There no good icon for sculptures in any case. Having icon for "paintings" is possible, but:

http://taginfo.openstreetmap.org/keys/artwork_type#values:
sculpture 15 942 56.73%
statue 8 394 29.87%

Please make a good enough icon for these 2 first rather how to include special case rendering of 1.25% :)

@kocio-pl
Copy link
Collaborator

So maybe we could design general statue icon, to match just the majority of cases (since 15% is relatively unimportant)?

@Jotam
Copy link

Jotam commented Jul 22, 2016

How about something very simple and very abstract?
artwork

@kocio-pl
Copy link
Collaborator

I don't know, but if you provide SVG link, I can test it visually at least.

@Jotam
Copy link

Jotam commented Jul 22, 2016

@Jotam
Copy link

Jotam commented Jul 22, 2016

And maybe also try this artwork
http://roeskamp.de/osm/artwork_02.svg

@kocio-pl
Copy link
Collaborator

Thanks! For me it looks like it's visually much better, because spiral pattern is lighter than mine (even crowded z18 is OK), but I feel it's too abstract.

Warsaw, z18:
krvbnqsn
z19:
blah0tdh

@kocio-pl
Copy link
Collaborator

Second pattern is too heavy IMO comparing to monument and museum icons:
ulntte0a
6s4sqxqx

tbjnlrlu

@Jotam
Copy link

Jotam commented Jul 22, 2016

Unfortunately, you are right about the second version. In places that are "cramped" with artwork, it's way to heavy. The question is if this makes sense at all. Don't get me wrong - I absolutely agree with tourism=artwork being rendered. But maybe only at the lowest zoom level. I quite like the icon when it's a single instance, though.

@Jotam
Copy link

Jotam commented Jul 22, 2016

The spiral shaped icon works fine. The fact that it's lighter is a good thing. Is it really too abstract? Some other opinions would be great.

@kocio-pl
Copy link
Collaborator

What about statue-like design (technically it's toilet+monument =} )? I like it. It's light, similar to info point lightness (small "i" letter), but it still resembles popular artwork type and works reasonably even in the worst case (crowded z17):

Saski Park (z17-z19):
kcjs1udm
qxgdsldr
ibeamvua

and Lazienki Park (z17-z19):
8jbdxibi
n4jwmurx
y6odp8hh

If we have more artwork-crowded places we could show only named artworks from z17 and the rest (without name) from z18.

@dieterdreist
Copy link

sent from a phone

Il giorno 22 lug 2016, alle ore 22:15, Jotam notifications@github.com ha scritto:

But maybe only at the lowest zoom level. I quite like the icon when it's a single instance, though.

we could watch out for the combination with attraction. Rendering artwork will make more sense when hstore is active and we can differentiate by type

@dieterdreist
Copy link

sent from a phone

Il giorno 22 lug 2016, alle ore 22:19, Jotam notifications@github.com ha scritto:

The spiral shaped icon works fine. The fact that it's lighter is a good thing. Is it really too abstract? Some other opinions would be great.

it's a bit too big, with 1 wind less it would be better I think. Generally it could work, but still e.g. in the case of a statue there is some discrepancy in the overall shape.

I could imagine also a tiny square (which doesn't convey any shape because more evidently represents a point) and a label

@Jotam
Copy link

Jotam commented Jul 22, 2016

Brilliant idea to combine "toilet" and "monument". :-) However, I see two problems: one is that it resembles the memorial icon. Another is that this proposal focuses only on statues. It would not be a good representation of graffiti, paintings, etc.

Your first approach (triangle, square, and circle) was very abstract. And I think we should pursue this idea further.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 22, 2016

For me it looks like the Oscar statue and is substantially different than memorial icon (compare both types in Lazienki Park for example).

I also think focus on ~85% of objects is a fair trade for now. However when hstore will be available I think we could use spiral for all the other artwork types (~15%).

@daganzdaanda
Copy link

I like that statue icon! It's very understandable and not intrusive. Great way to recycle existing elements and still be different enough to avoid confusion.

Tag-Info at the moment:

sculpture 16 000 56.69%
statue 8 433 29.88%

But from the wiki:

A sculpture is a work made of stone, metal, ceramic, wood or other material. If the work represents people or animals, you should use artwork_type=statue instead.

So, ~70% of artwork_types are not statues. Sculptures are probably mostly abstract, and could use a more abstract icon, like the spiral.

What about making the spiral a bit smaller like @dieterdreist said? maybe 1,5 turns would already be enough, and could allow for thickening the line a bit?

Another idea would be to use the small pedestal from the "oscar statue" and put a small diamond shape and a circle on top of it. So its similar in size and shape (not so dense), but more abstract.

@Jotam
Copy link

Jotam commented Jul 23, 2016

I tried both your suggestions. Unfortunately, 1,5 turns don't work for the spiral. It's hardly a spiral any more. But 2,3 turns are fine. See here: http://roeskamp.de/osm/artwork_01-02.svg

I also liked your other idea with the diamond. I had started to think into the same direction already. :-) Is this like what you had in mind? http://roeskamp.de/osm/artwork_03.svg

@Jotam
Copy link

Jotam commented Jul 23, 2016

@kocio-pl: Great idea to distinguish between different kinds of artwork. As I said, I like your statue icon for statues. If we could have something more abstract for everything else, that would be perfect.

@matthijsmelissen
Copy link
Collaborator Author

We should really be careful not to overcrowd the map. At the given zoomlevels, I think the art works are not relevant enough compared to the other features, I'd recommend rendering from z18 on.

@dieterdreist
Copy link

dieterdreist commented Jul 23, 2016 via email

@dieterdreist
Copy link

dieterdreist commented Jul 23, 2016

artwork_1 1

artwork_2 2

artwork_3 3

artwork_4 4

artwork_5 5

artwork_6 6

artwork_7 7

@dieterdreist
Copy link

the svg have been rejected but are available

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 23, 2016

I just put icons into code branch, probably also "gists" (loose code collections) are possible here?

I would try rendering with 5.

BTW: simple rectangular maze could be another idea - it would be better pixel aligned than spiral, so I guess also more crisp.

@dieterdreist
Copy link

2016-07-23 17:09 GMT+02:00 kocio-pl notifications@github.com:

I would try rendering with 5.

+1, I would try 5 and 7, unfortunately don't have a working rendering stack
around at the moment...

@matthijsmelissen
Copy link
Collaborator Author

I would like to see a rendering with 7.

1-5 are not recognizable enough to me (if anything, they'd represent a fire extinguisher to me).

@kocio-pl
Copy link
Collaborator

  1. artwork_03
    owec1ett
    q7ftfah0

  2. 7-like diamond (10 px)
    46tn7stv
    ebwr0duw

@Jotam
Copy link

Jotam commented Jul 24, 2016

After all those suggestions, I think I prefer @daganzdaanda's idea with the pedestal, diamond, and circle. It's light enough on the map, concrete enough to symbolize a statue, and abstract enough to represent sculptures and other artworks. It seems to meet all our requirements so far.

@dieterdreist
Copy link

sent from a phone

Il giorno 24 lug 2016, alle ore 10:02, Jotam notifications@github.com ha scritto:

It's light enough on the map, concrete enough to symbolize a statue, and abstract enough to represent sculptures and other artworks. It seems to meet all our requirements so far.

IMHO it's clearly a statue an not suitable for paintings, graffiti, landart, etc.

@kocio-pl
Copy link
Collaborator

I also like the simple and abstract diamond icon. It is as universal as the spiral, but I agree with @math1985 that the spiral may look like a fire equipment (I didn't make such connection myself, but in fact there's similar icon in JOSM) and diamond look more like a "gem" on game maps to me - which I feel is consistent with the idea of the "artwork" on the real map.

So for now I would like to use diamond as a general artwork icon from z18 (to not overcrowd z17, which seems like a land between mapping and micromapping world). After we have hstore available, I would also add statue icon only for statues (~30% of artworks) and show "special" artworks earlier, like z16 or z17 (when we have "tourist_attraction=yes" established as an alternative form for "tourism=attraction").

What do you think about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests