Open log files with O_APPEND so log rotation can work properly #9468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If logging to a file is used, and external log rotation is setup e.g. with logrotate, teleport would end up creating a sparse file because `write`s to the log file opened without O_APPEND would resume writing to the last write location even though the log file might have been truncated by logrotate. Fix this by opening the log file with O_APPEND. This will cause all subsequent `write`s to write to the end of the file, thus starting from the beginning of the empty file after a truncate has been performed by logrotate.
r0mant
approved these changes
Jan 5, 2022
zmb3
approved these changes
Jul 14, 2022
|
/gcbrun |
|
Hey @vrivanov-rb, thanks for the change, we'd like to merge this. Can you rebase it or do you want us to take it over? |
russjones
requested changes
Jul 27, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If logging to a file is used, and external log rotation is setup e.g. with logrotate, teleport would end up creating a sparse file because
writes to the log file opened without O_APPEND would resume writing to the last write location even though the log file might have been truncated by logrotate.Fix this by opening the log file with O_APPEND. This will cause all subsequent
writes to write to the end of the file, thus starting from the beginning of the empty file after a truncate has been performed by logrotate.