Updated log file creation mode. #6589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated log file creation mode to "O_WRONLY|O_CREATE|O_APPEND", instead of the default "O_RDWR|O_CREATE|O_TRUNC" by os.Create. This allows logs to persist across process restarts.
r0mant
approved these changes
Apr 24, 2021
webvictim
approved these changes
Apr 26, 2021
|
@klizhentas Can you take a look at this, changes Teleport behavior to always to log file instead of create new one on each process restart. |
|
This needs a signal for post logrotate to reopen the files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated log file creation mode to
O_WRONLY|O_CREATE|O_APPEND, instead of the defaultO_RDWR|O_CREATE|O_TRUNCbyos.Create.This allows logs to persist across process restarts.