-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube] Drop usage of ProcessKubeCSR
#46779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added
backport/branch/v14
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
backport/branch/v16
labels
Sep 19, 2024
tigrato
force-pushed
the
tigrato/drop-kubecsr-usage
branch
from
September 19, 2024 19:01
320bcff
to
189b11e
Compare
rosstimothy
approved these changes
Sep 19, 2024
bernardjkim
approved these changes
Sep 19, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
September 19, 2024 20:30
tigrato
force-pushed
the
tigrato/drop-kubecsr-usage
branch
from
September 20, 2024 07:57
4f8c5b2
to
7c2c2bd
Compare
This PR drops the usage of `ProcessKubeCSR` to ask Auth to sign a certificate on behalf of a user when running `tsh request search --kind=pod,...`. Previously, we used `ProcessKubeCSR` to sign a new certificate but given that Kubernetes Access supports impersonation, this PR levarages it. This also allows reusing the same kubernetes client for multiple calls.
tigrato
force-pushed
the
tigrato/drop-kubecsr-usage
branch
from
September 20, 2024 08:53
7c2c2bd
to
b03e463
Compare
strideynet
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🦸
@@ -5203,6 +5203,8 @@ func (a *ServerWithRoles) DeleteSemaphore(ctx context.Context, filter types.Sema | |||
|
|||
// ProcessKubeCSR processes CSR request against Kubernetes CA, returns | |||
// signed certificate if successful. | |||
// DEPRECATED | |||
// TODO(tigrato): DELETE IN 18.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
tigrato
force-pushed
the
tigrato/drop-kubecsr-usage
branch
from
September 20, 2024 09:39
b63bcf2
to
ccf0518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v14
backport/branch/v15
backport/branch/v16
no-changelog
Indicates that a PR does not require a changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the usage of
ProcessKubeCSR
to ask Auth to sign a certificate on behalf of a user when runningtsh request search --kind=pod,...
. Previously, we usedProcessKubeCSR
to sign a new certificate but given that Kubernetes Access supports impersonation, this PR leverages it.This also allows reusing the same kubernetes client for multiple calls.