add deprecation notices to ProcessKubeCSR

gravitational · Sep 20, 2024 · b03e463 · b03e463
1 parent 83c7007
commit b03e463
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/lib/auth/auth_with_roles.go b/lib/auth/auth_with_roles.go
@@ -5203,6 +5203,8 @@ func (a *ServerWithRoles) DeleteSemaphore(ctx context.Context, filter types.Sema
 
 // ProcessKubeCSR processes CSR request against Kubernetes CA, returns
 // signed certificate if successful.
+// DEPRECATED
+// TODO(tigrato): DELETE IN 18.0
 func (a *ServerWithRoles) ProcessKubeCSR(req authclient.KubeCSR) (*authclient.KubeCSRResponse, error) {
 	// limits the requests types to proxies to make it harder to break
 	if !a.hasBuiltinRole(types.RoleProxy) {

diff --git a/lib/auth/authclient/http_client.go b/lib/auth/authclient/http_client.go
@@ -323,6 +323,8 @@ func (c *HTTPClient) Delete(ctx context.Context, u string) (*roundtrip.Response,
 
 // ProcessKubeCSR processes CSR request against Kubernetes CA, returns
 // signed certificate if successful.
+// DEPRECATED
+// TODO(tigrato): DELETE IN 18.0
 func (c *HTTPClient) ProcessKubeCSR(req KubeCSR) (*KubeCSRResponse, error) {
 	if err := req.CheckAndSetDefaults(); err != nil {
 		return nil, trace.Wrap(err)

diff --git a/lib/auth/kube.go b/lib/auth/kube.go
@@ -34,6 +34,8 @@ import (
 
 // ProcessKubeCSR processes CSR request against Kubernetes CA, returns
 // signed certificate if successful.
+// DEPRECATED
+// TODO(tigrato): DELETE IN 18.0
 func (a *Server) ProcessKubeCSR(req authclient.KubeCSR) (*authclient.KubeCSRResponse, error) {
 	ctx := context.TODO()
 	if err := enforceLicense(types.KindKubernetesCluster); err != nil {

diff --git a/lib/service/service_test.go b/lib/service/service_test.go
@@ -1305,7 +1305,7 @@ func TestProxyGRPCServers(t *testing.T) {
 		limiter:       limiter,
 		conn:          testConnector,
 		listener:      secureListener,
-		kubeProxyAddr: *utils.MustParseAddr(secureListener.Addr().String()),
+		kubeProxyAddr: utils.FromAddr(secureListener.Addr()),
 		accessPoint:   testConnector.Client,
 		lockWatcher:   proxyLockWatcher,
 		emitter:       testConnector.Client,