-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding extra pod labels to post-upgrade and post-delete hook job pods #46029
Changes from 6 commits
d67b68c
d2caf2c
a563506
0d0c794
8b6ec76
e07d766
db51071
67ab90c
5906b53
4ee6671
82d8090
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After debugging a situation with a customer, I realized this is still useful. can you please re-add it and add support for the annotations and labels? sorry about the confusion There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem at all |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this hook because it was only important for v10--> v11 migration.
Since we are in v16 and v11 is not supported since v14, it should be fine to delete the whole hook