Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra pod labels to post-upgrade and post-delete hook job pods #46029

Merged
merged 11 commits into from
Sep 4, 2024

Conversation

mvbrock
Copy link
Contributor

@mvbrock mvbrock commented Aug 29, 2024

Adding extra pod labels to the post-upgrade and post-delete hook job pods. Verified that the labels show up in the post delete hook when uninstalling the kube-agent Helm chart:

metadata:
  annotations:
    testLabel: testValue

Fixes: #45114
Changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent Helm chart.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@mvbrock mvbrock requested review from tigrato and jakule August 29, 2024 16:14
Copy link
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the HELM tests job because they are currently failing:
https://github.com/gravitational/teleport/actions/runs/10618573216/job/29434142089?pr=46029

The changelog should be a customer-focused message that clearly communicates what has changed, such as:

Changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent Helm chart.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this hook because it was only important for v10--> v11 migration.
Since we are in v16 and v11 is not supported since v14, it should be fine to delete the whole hook

Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
@mvbrock mvbrock requested a review from tigrato August 30, 2024 13:20
Copy link
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After debugging a situation with a customer, I realized this is still useful. can you please re-add it and add support for the annotations and labels?

sorry about the confusion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem at all

@mvbrock mvbrock requested a review from tigrato September 4, 2024 14:24
Copy link
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merged via the queue into master with commit c128c3a Sep 4, 2024
41 of 42 checks passed
@mvbrock mvbrock deleted the mvbrock/helm-kube-agent-labels-fix branch September 4, 2024 14:46
@public-teleport-github-review-bot

@mvbrock See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[teleport-kube-agent chart] extraLabels.pod values are not templated for the teleport-delete-hook (Job) pods
3 participants