-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding extra pod labels to post-upgrade and post-delete hook job pods #46029
Conversation
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the HELM tests job because they are currently failing:
https://github.com/gravitational/teleport/actions/runs/10618573216/job/29434142089?pr=46029
The changelog should be a customer-focused message that clearly communicates what has changed, such as:
Changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent
Helm chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this hook because it was only important for v10--> v11 migration.
Since we are in v16 and v11 is not supported since v14, it should be fine to delete the whole hook
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After debugging a situation with a customer, I realized this is still useful. can you please re-add it and add support for the annotations and labels?
sorry about the confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adding extra pod labels to the post-upgrade and post-delete hook job pods. Verified that the labels show up in the post delete hook when uninstalling the kube-agent Helm chart:
Fixes: #45114
Changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent Helm chart.