Remove feature flag for VNet launch daemon #44923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
commented
Aug 1, 2024
| @@ -80,4 +80,5 @@ enum BackgroundItemStatus { | |||
| BACKGROUND_ITEM_STATUS_ENABLED = 2; | |||
| BACKGROUND_ITEM_STATUS_REQUIRES_APPROVAL = 3; | |||
| BACKGROUND_ITEM_STATUS_NOT_FOUND = 4; | |||
| BACKGROUND_ITEM_STATUS_NOT_SUPPORTED = 5; | |||
There was a problem hiding this comment.
Negative values for enum are supported but not recommended, so I just used 5 instead. On top of that, BackgroundItemStatus in protos already doesn't map 1:1 to the actual status returned by macOS, because 0 returned by macOS means "not registered", whereas in protos 0 should be reserved "unspecified".
github-actions
bot
added
documentation
size/sm
tsh
github-actions
bot
requested review from
kimlisa,
mmcallister,
ptgott,
r0mant,
rudream,
ryanclark,
xinding33 and
zmb3
ravicious
force-pushed
the
r7s/vnet-flag
branch
from
5befd7a
to
949c9ad
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gzdunek
approved these changes
Aug 1, 2024
|
🤖 Vercel preview here: https://docs-9ycc1w2ah-goteleport.vercel.app/docs/ver/preview |
zmb3
approved these changes
Aug 1, 2024
public-teleport-github-review-bot
bot
removed request for
avatus,
mmcallister and
ptgott
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
@ravicious See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also updates the docs to reflect this change.
On top of that, it makes sure that osascript can't be used for VNet if tsh was compiled with launch daemon support. I wanted to keep osascript as a fallback, configurable through a flag in the config, in case the launch daemon implementation turned out to be faulty. But now that we insecurely pass euid and egid through argv when osascript is used (#44751), it really is only meant to be used in development.
I also made sure that the notification about enabling the background item is not shown on macOS < 13.0 which does not support
SMAppService. We already returned-1as the daemon status in that scenario, but when converting it to a gRPC enum it got translated to theUNSPECIFIEDvariant and then the logic was faulty as well – we showed the notification as long as daemon status wasn'tENABLED. I added an explicitNOT_SUPPORTEDvariant.changelog: Added a background item for VNet in Teleport Connect; VNet now prompts for a password only during the first launch