Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeQL: Fix Go 1.21 build fix and update branch list #31892

Merged
merged 2 commits into from
Sep 14, 2023
Merged

CodeQL: Fix Go 1.21 build fix and update branch list #31892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90dc492
CodeQL: Set go version based off go.mod
jentfoo Sep 14, 2023
86681fc
CodeQL: Update branch list to drop v11 and include v14
jentfoo Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
branch: [ 'master', 'branch/v11', 'branch/v12', 'branch/v13' ]
branch: [ 'master', 'branch/v12', 'branch/v13', 'branch/v14' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep branch/v11 for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CodeQL I think it is safe to drop v11.

We're getting little negative signal out of these the recurring checks AFAIK. The hassle of remembering to remove v11 is a greater cost to the org than the chance we miss something important on v11 in the next week.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wadells is echo'ing my thoughts as well. It's a small time window and any changes in v11 should go through other branches first anyways. So the window of risk is small and since this is a workflow update this PR needs significant approval: https://github.com/gravitational/teleport/blob/master/.github/CODEOWNERS#L3

language: [ 'go', 'javascript' ]

steps:
Expand All @@ -30,6 +30,7 @@ jobs:
uses: actions/setup-go@v4
with:
cache: false
go-version-file: go.mod
if: ${{ matrix.language == 'go' }}

- name: Initialize the CodeQL tools for scanning
Expand Down
Loading