CodeQL: Fix Go 1.21 build fix and update branch list #31892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentfoo
force-pushed
the
jent/CodeQL_go_fix
branch
from
b9241f6
to
86681fc
Compare
jentfoo
changed the title
jentfoo
requested review from
klizhentas,
russjones,
r0mant and
zmb3
as code owners
codingllama
approved these changes
Sep 14, 2023
| @@ -17,7 +17,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| branch: [ 'master', 'branch/v11', 'branch/v12', 'branch/v13' ] | |||
| branch: [ 'master', 'branch/v12', 'branch/v13', 'branch/v14' ] | |||
There was a problem hiding this comment.
Should we keep branch/v11 for now?
There was a problem hiding this comment.
For CodeQL I think it is safe to drop v11.
We're getting little negative signal out of these the recurring checks AFAIK. The hassle of remembering to remove v11 is a greater cost to the org than the chance we miss something important on v11 in the next week.
There was a problem hiding this comment.
@wadells is echo'ing my thoughts as well. It's a small time window and any changes in v11 should go through other branches first anyways. So the window of risk is small and since this is a workflow update this PR needs significant approval: https://github.com/gravitational/teleport/blob/master/.github/CODEOWNERS#L3
wadells
approved these changes
Sep 14, 2023
rosstimothy
approved these changes
Sep 14, 2023
public-teleport-github-review-bot
bot
removed the request for review
from adaadb6
zmb3
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CodeQL Build and update branch list to include the v14 branch.
This PR fixes https://github.com/gravitational/SecOps/issues/414
Test build and analysis can be seen in this run: https://github.com/gravitational/teleport/actions/runs/6188331568/job/16800106312?pr=31892