This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Forward port RPC credentials rotation on upgrade #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadells
reviewed
Jul 30, 2021
lib/blob/fs/fs.go
Outdated
| if path == "" { | ||
| return nil, trace.BadParameter("missing Path parameter") | ||
| // New creates a new instance of the local fs blob service | ||
| // rooted as the given path |
There was a problem hiding this comment.
Suggested change
| // rooted as the given path | |
| // rooted at the given path |
| return p.HostLocalBackend.SetServiceUser(p.ServiceUser.OSUser()) | ||
| } | ||
|
|
||
| func (p *updatePhaseBootstrap) pullSystemUpdates(ctx context.Context) error { |
a-palchikov
force-pushed
the
dmitri/1623-rotate-rpc-creds
branch
from
66d1f35
to
c2f520d
Compare
|
Update the PR description with test steps performed. |
knisbet
approved these changes
Aug 13, 2021
lib/storage/keyval/system.go
Outdated
| return b.upsertVal(b.key(systemP, nodeAddrP), addr, forever) | ||
| } | ||
|
|
||
| // GetServiceUser returns the current serviceo user |
There was a problem hiding this comment.
Suggested change
| // GetServiceUser returns the current serviceo user | |
| // GetServiceUser returns the current service user |
| @@ -50,3 +50,33 @@ func (b *backend) GetSELinux() (enabled bool, err error) { | |||
| func (b *backend) SetSELinux(enabled bool) error { | |||
| return b.upsertVal(b.key(systemP, seLinuxP), &enabled, forever) | |||
| } | |||
|
|
|||
| // GetNodeAddr returns the current node advertise IP | |||
| func (b *backend) GetNodeAddr() (addr string, err error) { | |||
There was a problem hiding this comment.
I realize this is probably just part of the port and already this way on other branches, I imagine it applies to just the local backend. I just find it funny, because the other backend is etcd, in which case each node would clobber others writes.
Not asking for any changes, just something I found interesting.
There was a problem hiding this comment.
Agree - moved the system metadata APIs to a separate interface in c059b97e
a-palchikov
force-pushed
the
dmitri/1623-rotate-rpc-creds
branch
from
c2f520d
to
c059b97
Compare
bernardjkim
approved these changes
Aug 16, 2021
a-palchikov
added a commit
to a-palchikov/gravity
that referenced
this pull request
Aug 17, 2021
wadells
approved these changes
Aug 27, 2021
a-palchikov
force-pushed
the
dmitri/1623-rotate-rpc-creds
branch
from
c059b97
to
5e87bbb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward port of #1749 to bring feature parity with 7.x.
Part of a bigger attempt to forward-port intermediate version support to 9.x.
Type of change
Linked tickets and other PRs
TODOs
Implementation
Performance/Scaling
Testing done
2.1. Trigger manual upgrade
2.2. Step over /init to rotate RPC credentials
2.3. Roll back the operation (to also restore credenetials)
Additional information