Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated String.prototype.substr() #1379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CommanderRoot
Copy link

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 23, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@acao
Copy link
Member

acao commented Apr 25, 2022

@CommanderRoot can you sign the CLA please?

@CommanderRoot
Copy link
Author

I apologize for not signing the CLA sooner, must have somehow missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants