Fix: make public API compatible with 'exactOptionalPropertyTypes' #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
It's recomended option that was added in TS 4.4 but our public API was not compatible with it. Meaning if project was using graphql-js and had this enabled this flag they lost ability to explicitly pass undefined values.
IvanGoncharov
force-pushed
the
pr_branch4
branch
from
069e6ff
to
a60f4fc
Compare
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jul 21, 2022
Continuation of graphql#3670 Basically allow to have code like this: ```js parse(document, GraphQLServerConfig.parserOptions) ``` to pass TS check with 'exactOptionalPropertyTypes'
IvanGoncharov
added a commit
that referenced
this pull request
Jul 22, 2022
Continuation of #3670 Basically allow to have code like this: ```js parse(document, GraphQLServerConfig.parserOptions) ``` to pass TS check with 'exactOptionalPropertyTypes'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exactOptionalPropertyTypesis recommended option that was added in TS 4.4 but our public APIwas not compatible with it.
Meaning if the project was using graphql-js and had this enabled this flag they lost the ability to pass
undefinedvalues explicitly.Context: discovered as part of #3649 investigation.