Fix: make public API compatible with 'exactOptionalPropertyTypes' (#3670

)
graphql · Jul 21, 2022 · bef5534 · bef5534
1 parent ffe37cb
commit bef5534
Show file tree

Hide file tree

Showing 17 changed files with 178 additions and 150 deletions.
diff --git a/integrationTests/ts/kitchenSink-test.ts b/integrationTests/ts/kitchenSink-test.ts
@@ -0,0 +1,16 @@
+import { GraphQLScalarType } from 'graphql/type';
+import { GraphQLError } from 'graphql/error';
+import type { NameNode } from 'graphql/language';
+import { Kind } from 'graphql/language';
+
+// Test subset of public APIs with "exactOptionalPropertyTypes" flag enabled
+new GraphQLScalarType({
+  name: 'SomeScalar',
+  serialize: undefined,
+  parseValue: undefined,
+  parseLiteral: undefined,
+});
+
+new GraphQLError('test', { nodes: undefined });
+
+const nameNode: NameNode = { kind: Kind.NAME, loc: undefined, value: 'test' };
diff --git a/integrationTests/ts/tsconfig.json b/integrationTests/ts/tsconfig.json
@@ -2,8 +2,9 @@
   "compilerOptions": {
     "module": "commonjs",
     "lib": ["es2019", "es2020.promise", "es2020.bigint", "es2020.string"],
-    "strict": true,
     "noEmit": true,
-    "types": []
+    "types": [],
+    "strict": true,
+    "exactOptionalPropertyTypes": true
   }
 }
diff --git a/src/error/GraphQLError.ts b/src/error/GraphQLError.ts
@@ -21,7 +21,7 @@ export interface GraphQLErrorExtensions {
 }
 
 export interface GraphQLErrorOptions {
-  nodes?: ReadonlyArray<ASTNode> | ASTNode | null;
+  nodes?: ReadonlyArray<ASTNode> | ASTNode | null | undefined;
   source?: Maybe<Source>;
   positions?: Maybe<ReadonlyArray<number>>;
   path?: Maybe<ReadonlyArray<string | number>>;

diff --git a/src/execution/__tests__/union-interface-test.ts b/src/execution/__tests__/union-interface-test.ts
@@ -44,8 +44,8 @@ class Cat {
 
 class Person {
   name: string;
-  pets?: ReadonlyArray<Dog | Cat>;
-  friends?: ReadonlyArray<Dog | Cat | Person>;
+  pets: ReadonlyArray<Dog | Cat> | undefined;
+  friends: ReadonlyArray<Dog | Cat | Person> | undefined;
 
   constructor(
     name: string,

diff --git a/src/execution/values.ts b/src/execution/values.ts
@@ -238,7 +238,7 @@ export function getArgumentValues(
  */
 export function getDirectiveValues(
   directiveDef: GraphQLDirective,
-  node: { readonly directives?: ReadonlyArray<DirectiveNode> },
+  node: { readonly directives?: ReadonlyArray<DirectiveNode> | undefined },
   variableValues?: Maybe<ObjMap<unknown>>,
 ): undefined | { [argument: string]: unknown } {
   const directiveNode = node.directives?.find(