-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL printer produces invalid documentation strings #2569
Comments
@pcarrier this is not an invalid result. The js string literals are auto escaped. `"Ex\\\\ample" scalar Foo`.split('') === [ "\"", "E", "x", "\\", "\\", "a", "m", "p", "l", "e", "\"", " ", "s", "c", "a", "l", "a", "r", " ", "F", "o", "o" ]
// true So the string provided to the parser actually has only 2 |
@pcarrier Please also note that block strings are treated slash just as slash: |
@hereisnaman Please ensure that we have such a similar test case in our tests. |
Thanks for the explanation, block strings are indeed simpler yet smarter than I had originally understood. |
With graphql-js 15.0.0:
which is an invalid escape according to the spec.
The text was updated successfully, but these errors were encountered: