Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL parser swallows invalid escaped #2570

Closed
pcarrier opened this issue May 21, 2020 · 1 comment
Closed

GraphQL parser swallows invalid escaped #2570

pcarrier opened this issue May 21, 2020 · 1 comment
Labels
question

Comments

@pcarrier
Copy link
Contributor

pcarrier commented May 21, 2020 •
edited
Loading

The string generated by #2569 passes the graphql-js 15.0.0 parser just fine despite being invalid GraphQL. I would suggest being more conservative with invalid escape sequences even if it's a breaking change, this lets bad GraphQL loose.
@IvanGoncharov
Copy link
Member

IvanGoncharov commented May 22, 2020 •
edited
Loading

@pcarrier Thanks for reporting, answered by @hereisnaman and me in #2569

This was referenced Apr 2, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcarrier @IvanGoncharov