Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

update graphql peerdep #411

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Conversation

graingert
Copy link
Contributor

This is a fixed version of #407

@IvanGoncharov
Copy link
Member

@graingert Great 👍
Can you also fix npm test?
Updating flow-bin will solve all Flow errors.
You also need to update error messages inside tests:
https://travis-ci.org/graphql/express-graphql/jobs/329899395#L827

@graingert
Copy link
Contributor Author

Was hoping it would just pass. Will have a fiddle locally

This is a fixed version of graphql#407

also update tests with the new graphql error messages.
@graingert
Copy link
Contributor Author

@IvanGoncharov I also had to update eslint.

@graingert
Copy link
Contributor Author

@IvanGoncharov can you also have a look at my other PRs: #410 #409

@IvanGoncharov
Copy link
Member

@graingert Great 👍
Now we need to wait for someone with commit rights to merge this PR.

@leebyron Can you please take a look?

@IvanGoncharov
Copy link
Member

@leebyron This is super simple PR that just add support for ^0.12.0 vesions of graphql-js and fix a few test. At the same time it blocks a lot of people including myself from upgrading to the new version of graphql.
Can you please take a look?

@IvanGoncharov
Copy link
Member

@leebyron Now that 0.13 is published can you please merge this PR and also add 0.13 to peerDependencies?

Without this change express-graphql is unusable 😭

@IvanGoncharov IvanGoncharov merged commit c3e48c5 into graphql:master Feb 15, 2018
@IvanGoncharov
Copy link
Member

@graingert Merged 🎉 Thank you for PR and sorry for the delay.
I will try to make release ASAP.

@graingert
Copy link
Contributor Author

graingert commented Feb 15, 2018 via email

@IvanGoncharov
Copy link
Member

@graingert I'm working on it.
I just got commits rights to this repo so I want to make a new release including all simple PRs.

@graingert
Copy link
Contributor Author

graingert commented Feb 15, 2018 via email

@graingert
Copy link
Contributor Author

graingert commented Feb 15, 2018 via email

@IvanGoncharov
Copy link
Member

@graingert It's planned to release graphql@14.0.0, so updating peer dependency will be required only after breaking changes: graphql/graphql-js#1005

@IvanGoncharov
Copy link
Member

@graingert 📦 v0.6.12 released with support for graphql v0.12.x and v0.13.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants