Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

index: add support abi encode/decode #172

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

evaporei
Copy link
Contributor

@evaporei evaporei commented Apr 5, 2021

Related issue: graphprotocol/graph-node#2348
Related pull request: graphprotocol/graph-node#2348

I think this Pull Request should have tests as well, how should I proceed with it?

@leoyvens
Copy link
Collaborator

leoyvens commented Apr 6, 2021

These should go in the ethereum namespace, in chains/ethereum.ts

@evaporei
Copy link
Contributor Author

evaporei commented Apr 6, 2021

@leoyvens , should it the two functions be exported directly on ethereum namespace, or should I keep the abi namespace inside of it?

ethereum.{decode, encode} vs ethereum.abi.{decode, encode}

@evaporei evaporei force-pushed the otavio/support-encode-decode-hosted-abi branch from 32a15da to 81d6540 Compare April 7, 2021 12:37
@leoyvens
Copy link
Collaborator

leoyvens commented Apr 7, 2021

@otaviopace they can be directly in the namespace, no need to nest it.

@evaporei
Copy link
Contributor Author

@leoyvens this and graph-node are finished, I'm looking to see how I can contribute to the docs

@leoyvens
Copy link
Collaborator

@otaviopace looks like you accidentally committed the lock file

@evaporei evaporei force-pushed the otavio/support-encode-decode-hosted-abi branch from 70bee2a to 82c2359 Compare April 14, 2021 18:23
@evaporei
Copy link
Contributor Author

@leoyvens I've removed the lock file, sorry!

@leoyvens
Copy link
Collaborator

You can merge and have the graph-node PR point to graph-ts master

@evaporei evaporei force-pushed the otavio/support-encode-decode-hosted-abi branch from 50ad163 to 2895882 Compare April 14, 2021 19:50
@evaporei evaporei merged commit 56adb62 into master Apr 14, 2021
@evaporei evaporei deleted the otavio/support-encode-decode-hosted-abi branch April 14, 2021 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants