Store synced_at_block_number when a deployment syncs
#5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use both `INTEGER` and `NUMERIC` types in the database to match how other block numbers are stored in the same table.
encalypto
force-pushed
the
store-synced-at-block-number
branch
from
ff96da4
to
2a27bbd
Compare
lutter
reviewed
Aug 29, 2024
| @@ -0,0 +1,2 @@ | |||
| ALTER TABLE subgraphs.subgraph_deployment ADD COLUMN synced_at_block_number NUMERIC; | |||
There was a problem hiding this comment.
It would be better to make that an int4, too. The fact that latest_ethereum_block_number is numeric is more a historical accident than anything we should continue doing for other places where we store block numbers. In an ideal world, we'd change al the columns that store block numbers and use numeric to int4 but that might be a bit delicate and nobody's done that, obviously.
zorancv
reviewed
Sep 10, 2024
| use subgraph_deployment as d; | ||
|
|
||
| // Work around a Diesel issue with serializing BigDecimals to numeric | ||
| let number = format!("{}::int4", block_ptr.number); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5566
We use both
INTEGERandNUMERICtypes in the database to match how other block numbers are stored in the same table.