Fix WritableStore::get_many and get_derived to not return stale values #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the queue had multiple entries, and an entity was modified by more than one entry, we would return the oldest value in the queue instead of the newest one from WritableStore::get_many and get_derived. This change makes sure that we always return the correct (newest) value in these situations
lutter
force-pushed
the
lutter/writable
branch
from
2267431
to
2891a76
Compare
mangas
approved these changes
Aug 16, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the queue had multiple entries, and an entity was modified by more than one entry, we would return the oldest value in the queue instead of the newest one from
WritableStore::get_manyandget_derived.This change makes sure that we always return the correct (newest) value in these situations