Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate a non-primary shard being down during startup #2727

Merged
merged 8 commits into from
Aug 27, 2021
Merged

Tolerate a non-primary shard being down during startup #2727

merged 8 commits into from
Aug 27, 2021

Commits on Aug 27, 2021

  1. store: Include the port when setting up fdw connections 

    Unfortunately, we can't just slap a "set port 'NNNN'" into the 'alter
server' statement since we have installations that have a server without a
port, and for those we first need to "add port 'NNNN'".
    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    e0b65f8 View commit details
    Browse the repository at this point in the history

  2. store: Map fdw tables without accessing the foreign server 

    When we initialize a connection pool, we should only assume that the
database for that pool is up and running. Previously, we used `import
foreign schema` to create fdw tables locally, but that requires that
Postgres access the remote server, and will therefore not work when that
server is not up.

We now create these tables by assuming the corresponding table on the
remote server has the same schema as our local table, which avoids
accessing the remote server. It also removes a subtle race where we could
have pulled in the schema from a remote server before that ran its latest
migrations.
    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    56ff92e View commit details
    Browse the repository at this point in the history

  3. store: Do not impl Deref for ConnectionPool 

    This helps make it clearer how the underlying Diesel pool is accessed
    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b59f512 View commit details
    Browse the repository at this point in the history

  4. store: Do not set connection timeout for ConnectioPool to 6hrs

    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3cd0686 View commit details
    Browse the repository at this point in the history

  5. node, store: Make ConnectionPool::setup not async

    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    79c18bd View commit details
    Browse the repository at this point in the history

  6. store: Return only StoreError from ConnectionPool methods

    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3265db9 View commit details
    Browse the repository at this point in the history

  7. graph, node, store: Tolerate shards not being available during startup 

    When one of the configured shards is not available, defer setting it
up (e.g., running migrations) until it becomes available.
    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    e19e5e2 View commit details
    Browse the repository at this point in the history

  8. store: Make the connection timeout configurable and default to 5s

    @lutter
    lutter committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    6775ad9 View commit details
    Browse the repository at this point in the history