Chain head watcher fallback #2723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoueh
reviewed
Aug 19, 2021
| BlockStream, BlockStreamMetrics, ChainHeadUpdateListener, ChainHeadUpdateStream, | ||
| TriggersAdapter, | ||
| }; | ||
| pub use block_stream::{BlockStream, BlockStreamMetrics, ChainHeadUpdateListener, TriggersAdapter}; |
There was a problem hiding this comment.
Do I have some ide/rustfmt misconfiguration?
There was a problem hiding this comment.
This wasn't just a reformat, the ChainHeadUpdateStream import was removed. And rustfmt runs on CI so you never have to worry about that.
leoyvens
commented
Aug 19, 2021
| let mut watcher = self.chain_head_update_watcher.clone(); | ||
| let watcher_fut: Pin<Box<dyn Future<Output = _> + Send>> = async move { | ||
| watcher | ||
| .changed() |
There was a problem hiding this comment.
On further testing, because this watcher will always have an unseen change since the original chain_head_update_watcher wasn't checked for the change. This is a deadly flaw in the PR since I don't see a good way to solve this, I'll rework this fallback with a different approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A re-implementation of #2378, since we've again seen the chain head update stream have issues in production in heavily loaded nodes, post the tokio upgrade. Generally it seems like a good idea to be robust to the listener going down, though this will likely work differently after the block stream is pipelined. Resolves #2714.