-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graphman rewind
#2373
Merged
Merged
Add graphman rewind
#2373
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
use std::convert::TryFrom; | ||
use std::sync::Arc; | ||
|
||
use graph::prelude::{anyhow, BlockNumber, EthereumBlockPointer, SubgraphDeploymentId}; | ||
use graph_store_postgres::SubgraphStore; | ||
|
||
pub fn run( | ||
store: Arc<SubgraphStore>, | ||
id: String, | ||
block_hash: String, | ||
block_number: BlockNumber, | ||
) -> Result<(), anyhow::Error> { | ||
let id = | ||
SubgraphDeploymentId::new(id).map_err(|id| anyhow!("illegal deployment id `{}`", id))?; | ||
let block_ptr_to = EthereumBlockPointer::try_from((block_hash.as_str(), block_number as i64)) | ||
.map_err(|e| anyhow!("error converting to block pointer: {}", e))?; | ||
|
||
store.rewind(id, block_ptr_to)?; | ||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just here because we revert block by block usually? It's not here because reverting many blocks at once breaks things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably used to be that we had to go block-by-block; but for quite some time now, it's been safe to jump the block pointer back (assuming you know that you are jumping to the correct block pointer, which this PR slyly puts on the user) All the reversion queries just look at things that happened at/after the given block.
I left that code in since I didn't want to muck with the 'normal' reversion code path.