store: Allow enforcing a timeout for SQL queries #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
requested changes
Mar 17, 2021
| /// timeout is local, i.e., can only be used within a transaction and | ||
| /// will be cleared at the end of the transaction | ||
| static ref STATEMENT_TIMEOUT: Option<String> = { | ||
| env::var("GRAPH_SQL_STATEMENT_TIMEOUT") |
There was a problem hiding this comment.
This is important, lets document it in environment_variables.md.
leoyvens
approved these changes
Mar 17, 2021
lutter
force-pushed
the
lutter/db-timeout
branch
from
70402dd
to
6c9735b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't great since the timeout is set through an environment variable - it would be better to derive it from the overall timeout for GraphQL queries, but that's a little more work.