Use a synthetic primary key for subgraph_deployment #2268
Merged
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/deployment
branch
from
3afea3f
to
9013781
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
8211bb8
to
e1490b5
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
9013781
to
698cda0
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
e1490b5
to
1f4edaf
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
698cda0
to
53a7906
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
1f4edaf
to
eb958e9
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
53a7906
to
a9e366c
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
eb958e9
to
04a13ff
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
a9e366c
to
01cfd1b
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
04a13ff
to
f405522
Compare
tilacog
approved these changes
Mar 17, 2021
lutter
force-pushed
the
lutter/deployment
branch
from
01cfd1b
to
7f30603
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
f405522
to
9d58a2b
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
7f30603
to
8fc990e
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
9d58a2b
to
7e3b776
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
8fc990e
to
5fffda2
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
7e3b776
to
4507eec
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
5fffda2
to
857dec3
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
4507eec
to
3060635
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
857dec3
to
64ccc6b
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
3060635
to
ae4fb48
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
64ccc6b
to
f530511
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
ae4fb48
to
6bb91b5
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
f530511
to
85b72ff
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
6bb91b5
to
42d1960
Compare
lutter
force-pushed
the
lutter/deployment
branch
from
85b72ff
to
af76792
Compare
lutter
force-pushed
the
lutter/deployment2
branch
from
42d1960
to
ba77f20
Compare
Make 'id' the primary key on subgraph_deployment so that entries there are identified with the same id as entries in deployment_schemas
lutter
force-pushed
the
lutter/deployment2
branch
from
ba77f20
to
46b19f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the primary key for
subgraph_deploymentto be the same as the pk fordeployment_schemas. It does the bare minimum necessary to arrange for that in the database, but does not yet contain the code changes required to move away from identifying deployments internally by their IPFS hash. That will come in a future PR.This PR sits on top of #2267 since manual intervention is needed in the sharded setup in the hosted service between these two PR's.