chain, server: Allow feature detection for specVersion < 0.0.4

chain/ethereum/tests/manifest.rs

@@ -542,3 +542,34 @@ dataSources:
             .is_none());
     });
 }
+
+#[test]
+fn can_detect_features_in_subgraphs_with_spec_version_lesser_than_0_0_4() {
+    const YAML: &str = "
+specVersion: 0.0.2
+features:
+  - nonFatalErrors
+dataSources: []
+schema:
+  file:
+    /: /ipfs/Qmschema
+";
+    test_store::run_test_sequentially(|store| async move {
+        let store = store.subgraph_store();
+        let unvalidated = resolve_unvalidated(YAML).await;
+        assert!(unvalidated
+            .validate(store.clone())
+            .expect_err("Validation must fail")
+            .into_iter()
+            .find(|e| {
+                matches!(
+                    e,
+                    SubgraphManifestValidationError::FeatureValidationError(_)
+                )
+            })
+            .is_none());
+
+        let manifest = resolve_manifest(YAML).await;
+        assert!(manifest.features.contains(&SubgraphFeature::NonFatalErrors))
+    });
+}

server/index-node/src/resolver.rs

@@ -2,7 +2,7 @@ use either::Either;
 use std::collections::{BTreeMap, HashMap};
 
 use graph::data::subgraph::features::detect_features;
-use graph::data::subgraph::{status, SPEC_VERSION_0_0_4};
+use graph::data::subgraph::status;
 use graph::prelude::*;
 use graph::{
     components::store::StatusStore,
@@ -199,11 +199,6 @@ where
                 .map_err(|_error| QueryExecutionError::SubgraphManifestResolveError)?
         };
 
-        // Feature management is not available for subgraphs with specVersion below 0.0.4
-        if *unvalidated_subgraph_manifest.spec_version() < SPEC_VERSION_0_0_4 {
-            return Err(QueryExecutionError::InvalidSubgraphManifest);
-        }
-
         // Then validate the subgraph we've just obtained.
         //
         // Note that feature valiadation errors will be inside the error variant vector (because