Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Examples to GraphNetDataModule #730

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

OscarBarreraGithub
Copy link
Collaborator

Update the example scripts to use the new GraphNeTDataModule #669

@OscarBarreraGithub
Copy link
Collaborator Author

Added the label argument to ParquetDataset as in #729

@RasmusOrsoe
Copy link
Collaborator

@OscarBarreraGithub thank you for this contribution.

As you can see, quite a few of the tests are failing. At least some of the errors is caused by a numpy version issue that is unrelated to your code. This error has been fixed on main, so I would suggest you update the branch. (Can be done easily by merging main into your branch).

Removed spam before and after '=' in line 126
Added 'labels' argument description
@RasmusOrsoe RasmusOrsoe self-requested a review August 6, 2024 06:21
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OscarBarreraGithub Thank you very much for this! PR is approved, and you can merge! 🚀

@OscarBarreraGithub OscarBarreraGithub merged commit 6e78d88 into graphnet-team:main Aug 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants