Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused params fix #727

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

Aske-Rosted
Copy link
Collaborator

Fixes an issue in the FourierEncoder class where an embedding is intantiated but unused leading to the runtime error reported in issue #722

@RasmusOrsoe
Copy link
Collaborator

@Aske-Rosted looks like black is failling and that there is a merge conflict

Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@Aske-Rosted Aske-Rosted merged commit 72c38d5 into graphnet-team:main Jul 1, 2024
14 checks passed
@Aske-Rosted Aske-Rosted deleted the embedding_unused_params branch July 1, 2024 00:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants