Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #488

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Add files via upload #488

merged 7 commits into from
Apr 18, 2023

Conversation

RasmusOrsoe
Copy link
Collaborator

Adds a getting started guide.

@asogaard should have fixed indentation

Adds a getting started guide.
Copy link
Collaborator

@asogaard asogaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RasmusOrsoe,

I have added one comment regarding the file name, and a few suggestions regarding indentation, but I think this is ready to merge. :)

getting_started.md Outdated Show resolved Hide resolved
getting_started.md Outdated Show resolved Hide resolved
getting_started.md Outdated Show resolved Hide resolved
getting_started.md Outdated Show resolved Hide resolved
getting_started.md Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the naming consistent with other Markdown files in the root directory, I think the file name should be all upper-case, i.e., GETTING_STARTED.md, alternatively TUTORIAL.md to be consistent with the title in the document.

RasmusOrsoe and others added 6 commits April 18, 2023 13:42
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
@RasmusOrsoe
Copy link
Collaborator Author

@asogaard done.

@codeclimate
Copy link

codeclimate bot commented Apr 18, 2023

Code Climate has analyzed commit 0b87664 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.8% (0.0% change).

View more on Code Climate.

@RasmusOrsoe RasmusOrsoe merged commit 4dc5163 into main Apr 18, 2023
RasmusOrsoe added a commit to RasmusOrsoe/graphnet that referenced this pull request Oct 25, 2023
@RasmusOrsoe RasmusOrsoe deleted the RasmusOrsoe-patch-2 branch April 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants