-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload #488
Add files via upload #488
Conversation
Adds a getting started guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RasmusOrsoe,
I have added one comment regarding the file name, and a few suggestions regarding indentation, but I think this is ready to merge. :)
getting_started.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the naming consistent with other Markdown files in the root directory, I think the file name should be all upper-case, i.e., GETTING_STARTED.md
, alternatively TUTORIAL.md
to be consistent with the title in the document.
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
@asogaard done. |
Code Climate has analyzed commit 0b87664 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.8% (0.0% change). View more on Code Climate. |
…atch-2 Add files via upload
Adds a getting started guide.
@asogaard should have fixed indentation