added I3QUESOExtractor #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asogaard
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Hi @RasmusOrsoe,
Thanks for this! I love QUESO, and have only made one optional suggestion. :)
Comment on lines
+36
to
+39
| try: | ||
| value = frame[key].value | ||
| except KeyError: | ||
| value = self._padding_value |
There was a problem hiding this comment.
I think something like this is more legible, but they're functionally the same.
Suggested change
| try: | |
| value = frame[key].value | |
| except KeyError: | |
| value = self._padding_value | |
| if key in frame: | |
| value = frame[key].value | |
| else: | |
| value = self._padding_value |
RasmusOrsoe
added a commit
to RasmusOrsoe/graphnet
that referenced
this pull request
Oct 25, 2023
added I3QUESOExtractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds I3Extractor for the graphnet-powered event selection for IceCube Upgrade named QUESO.