-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EXT-X-SCTE when encoding playlists #41
Conversation
@vishal24tuniki if you have a moment, can you look over this and ensure it's behaving as expected, if you're OK with it, I'll merge. |
@bradleyfalzon Yes sure, will go over it in couple of hours :) |
@@ -449,6 +449,22 @@ func (p *MediaPlaylist) Encode() *bytes.Buffer { | |||
if p.winsize > 0 { // skip for VOD playlists, where winsize = 0 | |||
i++ | |||
} | |||
if seg.SCTE != nil { | |||
p.buf.WriteString("#EXT-X-SCTE:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the tag to #EXT-SCTE35 from #EXT-X-SCTE
@bradleyfalzon Everything looks fine. Just the SCTE tag is wrong as mentioned in the inline code comments |
Brilliant, thanks @vishal24tuniki |
Support EXT-X-SCTE when encoding playlists
#EXT-SCTE: is still wrong, its #EXT-SCTE35: |
Support EXT-X-SCTE when encoding playlists
Expands upon #40 to support encoding the SCTE segments into a playlist.
Such that the following:
Outputs: