Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to using sobek instead of goja #189

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Change to using sobek instead of goja #189

merged 1 commit into from
Jun 7, 2024

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Jun 6, 2024

We are moving to a fork of goja under grafana org called sobek.

More info in:

@mstoykov mstoykov requested a review from a team as a code owner June 6, 2024 13:27
@mstoykov mstoykov requested review from szkiba and removed request for a team June 6, 2024 13:27
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mstoykov mstoykov changed the title Change to using serbo instead of goja Change to using sebok instead of goja Jun 6, 2024
@szkiba
Copy link
Collaborator

szkiba commented Jun 6, 2024

@mstoykov the missing UncapFieldNameMapper alias block this PR....

@mstoykov mstoykov changed the title Change to using sebok instead of goja Change to using sobek instead of goja Jun 6, 2024
We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773
@mstoykov
Copy link
Contributor Author

mstoykov commented Jun 7, 2024

@szkiba this now should be mergeable

@szkiba szkiba merged commit 6327bc5 into master Jun 7, 2024
9 of 10 checks passed
@szkiba szkiba deleted the useSerbo branch June 7, 2024 09:55
Copy link
Collaborator

@szkiba szkiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants