-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zone aware ingesters #1936
Zone aware ingesters #1936
Conversation
0ea1509
to
7687060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this addition the jsonnet as well as a bit of cleanup. I had one small comment so far.
This is an impressive feature addition that uses features of the ring I have not had a chance to dig into myself. I have never run zone aware ingesters in Tempo so it's going to take me a bit longer to review this PR. Likely I will need to just run this locally and confirm everything is working as expected. Primarily commenting to let you know this is on my list and will get a proper review shortly.
880c8ff
to
f1dd917
Compare
Thank you for letting me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some basic testing on this. The basic jsonnet started up fine and everything was working.
However, when I added _config.multi_zone_ingster_enabled: true
I received this error:
Error: evaluating jsonnet: RUNTIME ERROR: Unexpected type null
During manifestation
By setting both multi_zone_ingester_enabled
and multi_zone_ingester_migration_enabled
to true
I was able to get it to render. Before I go further can we get a readme in ./operations/jsonnet/microservices
that describes how to use these fields correctly?
Honestly we should already have one to help people make sense of the jsonnet. This will be a good start.
This is because here it is using |
Thanks for the fix, but I would still like a description of how to use these config values in a readme. Can you create
This will help me and others understand how to use the 4 added config values if they want to use multizone. |
d63b224
to
08770b3
Compare
@joe-elliott added new readme file. |
08770b3
to
e157002
Compare
Any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I didn't mean to document using the jsonnet itself. I was just hoping for a few lines on the various multizone configuration options. I've run this locally and it LGTM.
Thanks!
What this PR does:
Add zone aware ingesters.
Which issue(s) this PR fixes:
Fixes #1578
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]