fix (v2): remove outdated compaction jobs from storage #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
changed the title
aleks-p
commented
Sep 5, 2024
| shard: j.Shard, | ||
| } | ||
| m.compactionJobQueue.evict(j.Name, math.MaxInt64) | ||
| stateUpdate.deletedJobs[key] = append(stateUpdate.deletedJobs[key], j.Name) |
There was a problem hiding this comment.
this is the actual bug fix, the rest is minor improvements (mostly logging)
korniltsev
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we encounter a job that has no valid blocks (e.g., because they were deleted by the truncation logic) we currently remove it from the in-memory store but not from bolt DB. This causes a burst of new (invalid) jobs every time we restore from a snapshot.
This change ensures that such jobs are removed. There are a few other (mostly cosmetic) changes as well.