adhocprofile: Validate IDs and santize names properly #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently allow any character to be user specified at upload. This limits that character set. It also makes sure only IDs are listend and retrieve with get, when they are fulfilling the character limit. This validation will ensure that the generated identifiers are withing the allowed set use for object store.
bryanhuhta
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyroscope currently allows any character to be user specified at upload. This limits that character set. It also makes sure only IDs are listed and retrieve with get, when they are fulfilling the character limit.
This validation will ensure that the generated identifiers are within the allowed set used by object stores.
Note: I don't think this is a security problem, as object store treat
..as a "normal folder name". Also the adhoc profiles are not enabled, when there is not bucket specified.