Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(distributor): Relabel profiles at ingest #3369

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Jun 19, 2024

This is an important operational tool: It allows us to deal with problems in the ingested profile labels.

The relabeling rules cover both series label and also sample labes.

By default we supply relabeling rules, which do remove the godeltaprof_ prefix from profiles generated by pyroscope-go.

This is an important operational tool: It allows us to deal with
problems in the ingested profile labels.

The relabeling rules cover both series label and also sample labes.

By default we supply relabeling rules, which do remove the godeltaprof_
prefix from profiles generated by pyroscope-go.
@simonswine simonswine changed the title WIP: Relabel at ingest Relabel profiles at ingest Jun 21, 2024
@simonswine simonswine changed the title Relabel profiles at ingest feat: Relabel profiles at ingest Jun 21, 2024
@simonswine simonswine changed the title feat: Relabel profiles at ingest feat(distributor): Relabel profiles at ingest Jun 21, 2024
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I added a few comments

pkg/distributor/distributor.go Outdated Show resolved Hide resolved
pkg/distributor/distributor.go Outdated Show resolved Hide resolved
pkg/distributor/distributor.go Show resolved Hide resolved
pkg/validation/relabeling_test.go Show resolved Hide resolved
I have also added the most common test cases I could think of.
@simonswine simonswine marked this pull request as ready for review June 25, 2024 10:12
@simonswine simonswine requested a review from a team as a code owner June 25, 2024 10:12
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine merged commit b6816e3 into grafana:main Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants