Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improves S3 example config #3275

Merged
merged 1 commit into from
May 3, 2024
Merged

docs: improves S3 example config #3275

merged 1 commit into from
May 3, 2024

Conversation

petethepig
Copy link
Member

Making sure it's less likely that people use grafana-pyroscope-data as their bucket name.

@petethepig petethepig requested review from a team as code owners May 3, 2024 19:05
bryanhuhta
bryanhuhta approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig merged commit 58f66fc into main May 3, 2024
16 checks passed
@petethepig petethepig deleted the docs-s3 branch May 3, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanhuhta bryanhuhta bryanhuhta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petethepig @bryanhuhta