-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix invalid references to targets
in discovery.relabel
#3153
docs: Fix invalid references to targets
in discovery.relabel
#3153
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
(cherry picked from commit 65be0e0)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3153-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 65be0e07d548a7f6e048fb419f9a0c8f58bb9465 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3153-to-release/v1.5
# Create the PR body template
PR_BODY=$(gh pr view 3153 --json body --template 'Backport 65be0e07d548a7f6e048fb419f9a0c8f58bb9465 from #3153{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release/v1.5] docs: Fix invalid references to `targets` in discovery.relabel" --body-file - --label "type/docs" --label "backport" --base release/v1.5 --milestone release/v1.5 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3153-to-release/v1.5
# Create a pull request where the `base` branch is `release/v1.5` and the `compare`/`head` branch is `backport-3153-to-release/v1.5`.
# Remove the local backport branch
git switch main
git branch -D backport-3153-to-release/v1.5 |
The component
discovery.relabel
exports a labeloutput
, but some code examples are trying to gettargets
field instead and failing.This PR fixes such invalid references.