Upgrade pyroscope-nodejs to v0.2.9 #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20240227_upgrade-pyroscope-nodejs
branch
from
ba53a22
to
78d2077
Compare
grafakus
reviewed
Feb 28, 2024
| @@ -2,7 +2,7 @@ | |||
| # yarn lockfile v1 | |||
|
|
|||
|
|
|||
| "@mapbox/node-pre-gyp@^1.0.0": | |||
| "@mapbox/node-pre-gyp@^1.0.9": | |||
There was a problem hiding this comment.
Why do we have changes in the lock file and not in express-pull/package.json?
There was a problem hiding this comment.
The lock file was unused in the dockerfile and so I resetted the whole lock file, to be closer what is running in the container
examples/language-sdk-instrumentation/nodejs/express-ts/package.json
Outdated
Show resolved
Hide resolved
examples/language-sdk-instrumentation/nodejs/express-ts/package.json
Outdated
Show resolved
Hide resolved
| version "1.0.8" | ||
| resolved "https://registry.yarnpkg.com/@mapbox/node-pre-gyp/-/node-pre-gyp-1.0.8.tgz#32abc8a5c624bc4e46c43d84dfb8b26d33a96f58" | ||
| integrity sha512-CMGKi28CF+qlbXh26hDe6NxCd7amqeAzEqnS6IHeO6LoaKyM/n+Xw3HT1COdq8cuioOdlKdqn/hCmqPUOMOywg== | ||
| "@mapbox/node-pre-gyp@^1.0.9": |
There was a problem hiding this comment.
Same comment as above for express-pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates pyrsocope-nodejs to latest version and it also fixes a small bug in nodejs memory scraping example express-pull.