Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebpf: run tests on many kernels #3025

Merged
merged 39 commits into from
Feb 29, 2024
Merged

ebpf: run tests on many kernels #3025

merged 39 commits into from
Feb 29, 2024

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Feb 26, 2024

Run ebpf tests on multiple kernels 5.4 5.10 5.15 6.1 5.10-amazon
4.19 does not work #3033

In the future: consider periodically building a kernel from the Linus master branch and from bpf-next branch

@korniltsev korniltsev marked this pull request as ready for review February 27, 2024 11:30
@korniltsev korniltsev requested a review from a team as a code owner February 27, 2024 11:30
@korniltsev korniltsev enabled auto-merge (squash) February 28, 2024 06:10
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

This will allow to catch future ebpf problems early.

I do think we shouldn't hide that many qemu errors, something might be a bit more transparent: https://github.com/pyroscope-io/pyroscope-ebpf-testdata/pull/2/files

@korniltsev
Copy link
Collaborator Author

Great!
In the future It would be nice to have kernel output if CI fails, just in case

@korniltsev korniltsev merged commit b6b7d6e into main Feb 29, 2024
27 checks passed
@korniltsev korniltsev deleted the ebpf/clang-format branch February 29, 2024 16:01
@korniltsev
Copy link
Collaborator Author

Interesting, qemu tests have not finished but it allowed me to merge :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants