Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploying make deploy-micro-services after make deploy #2921

Merged

Conversation

simonswine
Copy link
Contributor

Make deploy manually creates a service to have the same endpoint for
single-binary and micro-services, which then interferes with the next
deployment of microservces.

Make deploy manually creates a service to have the same endpoint for
single-binary and micro-services, which then interferes with the next
deployment of microservces.
@simonswine simonswine requested a review from a team as a code owner January 12, 2024 12:04
@simonswine simonswine changed the title Fix deployming make deploy-micro-services after make deploy Fix deploying make deploy-micro-services after make deploy Jan 12, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine merged commit 52b7da5 into grafana:main Jan 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants