feat: Extract main binary version from labels #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/model/labels.go
Outdated
Comment on lines
36
to
37
| LabelNameMappingRepository = "__mapping_repository__" | ||
| LabelNameMappingCommit = "__mapping_commit__" |
There was a problem hiding this comment.
I would consider not making them reserved.
- It will probably affect the data locality:
__mapping_*goes before__service_*, therefore profiles of the same service but different versions can be stored far from each other. - Reserved labels are discarded in the
/ingestendpoint. - Users may want to use them, esp.
commite.g., for comparison. Although, we could copy them with a public name.
Should we use service instead of mapping? mapping is very specific to how we currently use it, not to its actual content.
Also, should we have a broader ref (commit/branch/tag) instead of commit? Github API is also using it. Or just version?
That being said, I propose to name them service_repository and service_version
There was a problem hiding this comment.
I will make the change, and yes we can use refs good idea this might be even easier for some people to integrate.
There was a problem hiding this comment.
Alright good catch on this. Let me know what you think now I've made some suggested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extract repository and commit from labels and inject them into the main binary mapping version.
This information can then be read using the pprof API.