Helm: Handle overriding extraArgs in components correctly #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
changed the title
I noticed a bug, when setting extraArgs on a single component (`.values.pyroscope.components.querier.extraArgs`) they would completely overwrite the whole global (`.values.pyroscope.extraArgs`) array. This change will make sure we do a merge of global and component based extraArgs.
simonswine
force-pushed
the
20231123_override-extra-args
branch
from
4d29b41
to
7c0fb59
Compare
simonswine
added a commit
that referenced
this pull request
Nov 23, 2023
I noticed a bug, when setting extraArgs on a single component (`.values.pyroscope.components.querier.extraArgs`) they would completely overwrite the whole global (`.values.pyroscope.extraArgs`) array. This change will make sure we do a merge of global and component based extraArgs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug, when setting extraArgs on a single component (
.values.pyroscope.components.querier.extraArgs) they would completely overwrite the whole global (.values.pyroscope.extraArgs) array.This change will make sure we do a merge of global and component based
extraArgs.